errorprone 2.3.3 -> 2.3.4 #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
* Fix GradleCacheableTaskAction on error-prone 2.3.4 * Fix Slf4jConstantLogMessageTests: Don't reuse CompilationHelper instances
|
👍 |
carterkozak
requested review from
carterkozak
and removed request for
ellisjoe
|
@iamdanfox this will need an approval from you as well since it includes my PR. |
iamdanfox
commented
Dec 3, 2019
| @@ -54,6 +54,7 @@ allprojects { | |||
| check("PreferSafeLoggableExceptions", CheckSeverity.OFF) | |||
| check("PreferSafeLoggingPreconditions", CheckSeverity.OFF) | |||
| check("PreconditionsConstantMessage", CheckSeverity.OFF) | |||
| check("GradleCacheableTaskAction", CheckSeverity.OFF) | |||
There was a problem hiding this comment.
We can re-enable this as soon as this repo upgrades to a version of baseline that includes this PR.
There was a problem hiding this comment.
It's really scary that a bump in error_prone_annotations alone (which looks like it should be a sort of API, not implementation) changes the implementation logic.
|
👍 bulldozer? |
|
Released 2.38.0 |
This was referenced Dec 3, 2019
This was referenced Dec 3, 2019
This was referenced Dec 16, 2019
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
error-prone's last release was in March, with a ton of cool stuff piled up on develop.
After this PR
==COMMIT_MSG==
We now run error-prone 2.3.4, to benefit from smarter static analysis, and hopefully pick up the claimed performance Improvements:
https://github.com/google/error-prone/releases
Possible downsides?